RFD: DW inbox buttons inactive for a number of people?

[pauamma]

So there's a bunch of requests, going back to at least December 2018 and maybe at least September 2018, all reporting that some buttons on the DW inbox have no effect when clicked. The buttons concerned are "Delete Selected", "Mark Read", "Mark Unread", and perhaps "Delete All". The requests themselves are:

https://www.dreamwidth.org/support/see_request?id=40012
https://www.dreamwidth.org/support/see_request?id=39872
https://www.dreamwidth.org/support/see_request?id=39869
https://www.dreamwidth.org/support/see_request?id=39827
https://www.dreamwidth.org/support/see_request?id=39796
https://www.dreamwidth.org/support/see_request?id=39626 (which has a copypasta of the Chrome console error log that may be a clue)
https://www.dreamwidth.org/support/see_request?id=39566
https://www.dreamwidth.org/support/see_request?id=39201
https://www.dreamwidth.org/support/see_request?id=38992 (but it is unclear to me whether this is the same problem)

However, the "Delete Selected" button works for me. Any opinion? Could it be add-ons interfering with Javascript? (The copypasta seems to me to be hinting at a code error in some Javascript library inherited from 6Apart instead, but I'm not a Javascript kinda crab.)

Comments

[kaberett]

... you are amazing, thank you so much for poking at this. In process of getting a bug filed for this now.

[kaisa]

No problem.

I guess I see three things to look at.

1. Waiting for the whole page to load before allowing js to run is not necessary a good idea, and I see that is dealt with nfagerlund's pull request. 👍

2. Why is image proxy request returning that 504 error when the url does return the badge image in browser? (There is a 301 Moved response first, but Go should be able to follow redirects automatically so maybe it is something else. I don't know enough about Go or the setup to troubleshoot this.) I'm just wondering if this is a bug, too.

3. To avoid unnecessary image proxy requests, it would probably make sense to change the hardcoded FanFiction badge image url to point directly to the https protocol, as they do serve it in https.

[pauamma]

Has https://github.com/dreamwidth/dw-free/pull/2491 been pushed to production? I'd like to check which of these requests are now fixed.

ETA 2019-08-22 *nudge*